Skip to content

fix: apply some building best practices

Christopher Dilksrequested to merge
misc-fixes into main

Following https://docs.docker.com/build/building/best-practices

  • use ADD instead of git clone, for more precise build cache
    • doesn't seem to work here, and we only care about cache usage on MR pipelines
    • for long-lived MRs, we may want to rebuild with no-cache, or we need to figure out how to cache bust both git clone and pacman -S usages
  • assign GID and UID 10001 to default user, and follow other recommended options
  • use WORKDIR once to be in /build instead of cd /build in every instruction
  • set CMD to an interactive shell
  • clone QADB with --recurse-submodules (might as well fix this now)
Edited by Christopher Dilks

Merge request reports